Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 shopinvader base url #1375

Closed

Conversation

sebastienbeau
Copy link
Contributor

@sebastienbeau sebastienbeau commented Jun 26, 2023

Ready for review.

The module have receive a big refactor, in order to work without "shopinvader.variant"

Now urls

  • are generated only when the method "_update_url_key" is called (so it should be called before the export)
  • a flag is set on the record if something have changed to avoid useless recomputation
  • url key are global by default (same for all website), but the it's easy with an extra module to change this behaviour

The module shopinvader_product_url generate the url for the category and the product

TODO

  • add the redirect from product to category when deleting a product

Resolves #1373

@sebastienbeau sebastienbeau marked this pull request as draft June 26, 2023 21:43
@sebastienbeau sebastienbeau marked this pull request as ready for review July 24, 2023 20:00
@marielejeune
Copy link
Contributor

@sebastienbeau Tests were run again. No more error due to fastapi.

@sebastienbeau
Copy link
Contributor Author

@lmignon @marielejeune it's green

@qgroulard
Copy link
Contributor

@sebastienbeau #1399
Here you'll find my contribution to this PR following our discussions last week.
Had to open a new PR as I couldn't push to akretion, feel free to cherry-pick :)

@sebastienbeau sebastienbeau added this to the 16.0 milestone Sep 25, 2023
@sebastienbeau
Copy link
Contributor Author

already merged here : #1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V16 base_url adaptation
3 participants