Fix readdir recursive issue by switching to glob #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonzhan2
approved these changes
Nov 6, 2024
mvirgil
force-pushed
the
fix-readdir-bug
branch
from
23bad93 to
5ca56d7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dirent.path was unexpectedly set to 'undefined', causing errors when passing undefined to path.join
Noticed errors locally when I was using Node v20.8.1, but they were not happening with v20.18.0
This bug should be fixed in later versions of v18 and v20, but switching to glob will make this easier to handle.
May refactor the calling code later (i.e. remove the util method, invoke glob directly), but simply replacing the implementation of the current util method is easiest.
See also:
nodejs/node#48858
nodejs/node#51773