Feature/demrum 440 dsyms list command #61
Conversation
| debug?: boolean; | ||
| } | ||
|
|
||
| iOSCommand |
There was a problem hiding this comment.
Which block? I'm seeing code that doesn't line up with a block above your comments, maybe the branch got out of sync with what's shown here(?).
src/commands/ios.ts
Outdated
| } | ||
| }); | ||
|
|
||
| iOSCommand.parse(process.argv); |
There was a problem hiding this comment.
I dont think this should be here. If you look in index.ts file, it has the program defined, adds the different commands and parses
There was a problem hiding this comment.
Removed; thanks.
src/utils/iOSInputValidations.ts
Outdated
There was a problem hiding this comment.
These look similar to whats in androidInputValidations. Perhaps we could consolidate it and make them generically useable for both android and iOS
There was a problem hiding this comment.
Good idea. I've added this update to the previous PR so once that is merged and I rebase this branch then we will see the change here as well.
carlosmcevilly
force-pushed
the
feature/DEMRUM-440-dsyms-list-command
branch
from
50d7924 to
c4e0895
Compare
src/commands/ios.ts
Outdated
| iOSCommand | ||
| .command('upload') | ||
| .showHelpAfterError(true) | ||
| .usage('--file <path>') | ||
| .description(iOSUploadDescription) | ||
| .summary('Upload a dSYMs .zip file to the symbolication service') | ||
| .requiredOption('--file <path>', 'Path to the dSYMs .zip file') | ||
| .option('--debug', 'Enable debug logs') |
There was a problem hiding this comment.
Is it intentional to remove --debug option from Upload right now? If so, you'd want to keep UploadiOSOptions in-sync
There was a problem hiding this comment.
Good point. I think I want to keep that actually.
Add command to request list of dSYMs from the cloud API.