-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/demrum 440 dsyms list command #61
Merged
carlosmcevilly
merged 12 commits into
signalfx:main
from
signalfx:feature/DEMRUM-440-dsyms-list-command
Jan 11, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cff578e
DEMRUM-439: add initial iOSInputValidations
carlosmcevilly acf1104
DEMRUM-439: implement iOS dSYMs upload
carlosmcevilly 7b8d627
DEMRUM-440: implement list command
carlosmcevilly cf512ce
DEMRUM-440: restore listdSYMsDescription
carlosmcevilly 2e79395
DEMRUM-439: remove unused validations
carlosmcevilly 0b52db2
DEMRUM-439: remove unused fields
carlosmcevilly 64469b0
DEMRUM-440: restore axios import
carlosmcevilly a0f036b
DEMRUM-440: fix missing semicolon
carlosmcevilly 4d3af2c
DEMRUM-440: remove now-unused iOSInputValidations.ts
carlosmcevilly 078c5b9
DEMRUM-440: add basic iOS unit test
carlosmcevilly c4e0895
DEMRUM-440: remove misplaced iOSCommand.parse() call
carlosmcevilly 61bcb74
DEMRUM: 440: restore debug option
carlosmcevilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/* | ||
* Copyright Splunk Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { iOSCommand } from '../../src/commands/ios'; | ||
|
||
describe('ios command', () => { | ||
test('has multiple sub-commands', () => { | ||
expect(iOSCommand.commands.length).toBe(2); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this block needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which block? I'm seeing code that doesn't line up with a block above your comments, maybe the branch got out of sync with what's shown here(?).