Add support for Python3.10 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
spencerschrock
previously approved these changes
Aug 27, 2024
src/model_signing/hashing/file.py
Outdated
Comment on lines
202
to
203
| else: | ||
| # Polyfill for Python 3.10 |
There was a problem hiding this comment.
TIL about polyfill. Just another term for backport?
Optional: The Go dev in me would say drop the else to reduce indentation one block, but dont know if this applies in Python so free to ignore.
There was a problem hiding this comment.
It's from Javascript, it's for anything that covers a gap in some implementation (like a browser missing some feature). In our case it's the same as backport.
Good idea on dropping the else. I shortened the link too, so now we don't have a line that is too long.
Signed-off-by: Mihai Maruseac <[email protected]>
spencerschrock
approved these changes
Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Suport Python 3.10 so that we can use the library in Google Colab without having to reinstall.
We only need 2 changes:
Selfneeds to be imported fromtyping_extensionshashlib.file_digestneeds to be implemented manually. I backported the implementation that Python uses, adapted to our scenario.Release Note
NONE
Documentation
NONE