Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]Rework #183

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[WIP]Rework #183

merged 4 commits into from
Feb 11, 2025

Conversation

Gillou68310
Copy link
Contributor

No description provided.

@Gillou68310
Copy link
Contributor Author

@1superchip

@Gillou68310 Gillou68310 changed the title Rework [WIP]Rework Feb 10, 2025
@simonlindholm
Copy link
Owner

@1superchip I gave you repo access, you can squash&merge this when it looks good to you

@1superchip
Copy link
Collaborator

We need to add call to instructions_with_address_immediates on

asm-differ/diff.py

Line 2612 in fc49910

instructions_with_address_immediates=X86_BRANCH_INSTRUCTIONS.union({"mov"}),

1superchip
1superchip reviewed Feb 11, 2025
View reviewed changes
@1superchip 1superchip merged commit f24945c into simonlindholm:main Feb 11, 2025
4 checks passed
@1superchip 1superchip mentioned this pull request Feb 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1superchip 1superchip 1superchip left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gillou68310 @simonlindholm @1superchip