Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] clean up and comment dep sets in pyproject.toml, remove unused graph dep set from CI #1650

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 4, 2024

Cleans up dependency management without making changes to existing dep sets.

  • create new dep set all_extras containing all used soft dependencies
  • reorder dep sets in pyproject.toml and and comments about their usage
  • remove unused graph dep set from installations in CI - the contained networkx package is never imported within the code base

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (81aee66) to head (c099bf0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   90.20%   90.20%           
=======================================
  Files          32       32           
  Lines        4729     4729           
=======================================
  Hits         4266     4266           
  Misses        463      463           
Flag Coverage Δ
cpu 90.20% <ø> (ø)
pytest 90.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 0a1e784 into master Sep 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants