Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] clean up and comment dep sets in pyproject.toml, remove unused graph dep set from CI #1650

Merged
merged 4 commits into from
Sep 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install ".[dev,github-actions,graph,mqf2]"
python -m pip install ".[dev,github-actions,mqf2]"

- name: Show dependencies
run: python -m pip list
Expand Down Expand Up @@ -103,7 +103,7 @@ jobs:
- name: Install dependencies
shell: bash
run: |
pip install ".[dev,github-actions,graph,mqf2]"
pip install ".[dev,all_extras,github-actions]"

- name: Show dependencies
run: python -m pip list
Expand Down
37 changes: 35 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,42 @@ dependencies = [
]

[project.optional-dependencies]
# there are the following dependency sets:
# - all_extras - all soft dependencies
# - granular dependency sets:
# - tuning - dependencies for tuning hyperparameters via optuna
# - mqf2 - dependencies for multivariate quantile loss
# - graph - dependencies for graph based forecasting
# - dev - the developer dependency set, for contributors to pytorch-forecasting
# - CI related: e.g., dev, github-actions. Not for users of sktime.
#
# soft dependencies are not required for the core functionality of sktime
# but are required by popular estimators, e.g., prophet, tbats, etc.

# all soft dependencies
#
# users can install via "pip install pytorch-forecasting[all_extras]"
#
all_extras = [
"cpflows",
"optuna >=3.1.0,<4.0.0",
"optuna-integration",
"statsmodels",
]

tuning = [
"optuna >=3.1.0,<4.0.0",
"optuna-integration",
"statsmodels",
]

mqf2 = ["cpflows"]

# the graph set is not currently used within pytorch-forecasting
# but is kept for future development, as it has already been released
graph = ["networkx"]

# dev - the developer dependency set, for contributors to pytorch-forecasting
dev = [
"pydocstyle >=6.1.1,<7.0.0",
# checks and make tools
Expand Down Expand Up @@ -101,8 +136,6 @@ dev = [
]

github-actions = ["pytest-github-actions-annotate-failures"]
graph = ["networkx"]
mqf2 = ["cpflows"]

[tool.setuptools.packages.find]
exclude = ["build_tools"]
Expand Down
Loading