Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 Fix reliability issues #42

Merged
merged 15 commits into from
Jul 8, 2019
Merged

33 Fix reliability issues #42

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
114e719
Add go modules
ja6a Jun 17, 2019
dd7c67e
initial investigation
ja6a Jun 20, 2019
4f31f8e
Add request run state prechecking
ja6a Jun 20, 2019
73e340e
Cut extra do method
ja6a Jun 21, 2019
9697e6c
Add response checking
ja6a Jun 21, 2019
c506f2b
Add response to review comments
ja6a Jun 28, 2019
ebf9536
Fix disk update routine. Fail early on 422 if resource not busy
ja6a Jun 30, 2019
6e581f4
Cut Update method and related structures
ja6a Jul 8, 2019
d4ef20c
Add requirement for vm to be stopped prior to interface delete
ja6a Jul 8, 2019
0f63b3f
Add environment busy check in place of vm ready check
ja6a Jul 8, 2019
642c98e
Add change to parameter name
ja6a Jul 8, 2019
3d924d1
Add new name for compare
ja6a Jul 8, 2019
97dcca1
Add clarity to method name
ja6a Jul 8, 2019
b928af7
Add improvement to readability of string formulation
ja6a Jul 8, 2019
9ce0aca
Add comment to clarify intention of running the environment
ja6a Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,20 @@ dist: trusty
sudo: required
language: go
go:
- "1.11"
- "1.11.x"
script:
- make build
- make test
- make vet
- go mod vendor
- make build
- make test
- make vet
branches:
only:
- v2
- master
- master
matrix:
fast_finish: true
allow_failures:
- go: tip
env:
- GOFLAGS=-mod=vendor GO111MODULE=on

5 changes: 3 additions & 2 deletions GNUmakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
TEST?=$$(go list ./...)
TEST?=$$(go list ./... | grep -v 'vendor')
GOFMT_FILES?=$$(find . -name '*.go')
GOIMPORT_FILES?=$$(find . -type f -name '*.go' -not -path './vendor/*')
PKG_NAME=skytap

default: build

build: fmtcheck
go mod vendor
go install ./skytap

test: fmtcheck
go get -t $(TEST)
go mod vendor
go test -i $(TEST) || exit 1
echo $(TEST) | \
xargs -t -n4 go test $(TESTARGS) -timeout=30s -parallel=4 -v
Expand Down
3 changes: 3 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/skytap/skytap-sdk-go

require github.com/stretchr/testify v1.3.0
7 changes: 7 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q=
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
Loading