Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 Fix reliability issues #42

Merged
merged 15 commits into from
Jul 8, 2019
Merged

33 Fix reliability issues #42

merged 15 commits into from
Jul 8, 2019

Conversation

ja6a
Copy link

@ja6a ja6a commented Jun 27, 2019

No description provided.

@ja6a ja6a changed the title Fix reliability issues 33 Fix reliability issues Jun 27, 2019
@ja6a ja6a requested a review from pegerto June 27, 2019 17:32
@pegerto
Copy link

pegerto commented Jun 28, 2019

The retry logic makes sense, the main concern is that we make assumptions of if need to be checked, will be nicer if this is pass to the client as a policy. Consider to leverage solutions as go-retryable and the implementation of a specific policy for the skytap client.

@ja6a
Copy link
Author

ja6a commented Jul 1, 2019

The retry logic makes sense, the main concern is that we make assumptions of if need to be checked, will be nicer if this is pass to the client as a policy. Consider to leverage solutions as go-retryable and the implementation of a specific policy for the skytap client.

I have addressed all the comments:- either directly in the code or by creating new issues to be addressed at a later date. Issues #45 #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants