ENH: ArchiveTimePlot Fetch Data on X-Axis Change #1172
Draft
+63
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I'm reading back through my code, I'm wondering if this should be an optional change. Should add a parameter to the ArchiveTimePlot constructor for getting data like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prompts the ArchiveTimePlot to get data from the Archiver Appliance every time the x-axis' range changes.
Previously, archive data was only fetched when the user showed a section of the plot that had no data. With this set up, zooming out will fetch a optimized data (averaged w/ min/max error bars), but zooming back in would still optimized data. This results in the "resolution" looking wrong.
Now zooming in on a section will get the data for the time range shown on the plot. This will result in showing the correct "resolution" at all times.