Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save StringConcat bytecode generation for one-time operation #317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franz1981
Copy link
Contributor

This has popup as a bytecode generation operation which can both save memory and CPU time at startup, see

image

It both save the lambda generation and, most importantly, a useless string concatenation.

@dmlloyd
Copy link
Collaborator

dmlloyd commented Jun 24, 2024

Why not just eliminate the string concatenation and keep the lambda? Keeping the lambda means one less class to load from disk.

@franz1981
Copy link
Contributor Author

@dmlloyd I have no strong opinion on this, so I can do it like that as well

@dmlloyd
Copy link
Collaborator

dmlloyd commented Jun 24, 2024

👍 it's probably better to keep the fix down to the thing being fixed when possible.

Comment on lines +34 to +43
final PrivilegedAction<Void> action = new PrivilegedAction<>() {
@Override
public Void run() {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final PrivilegedAction<Void> action = new PrivilegedAction<>() {
@Override
public Void run() {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
}
};
final PrivilegedAction<Void> action = () -> {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants