Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save StringConcat bytecode generation for one-time operation #317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Save StringConcat bytecode generation for one-time operation #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions ref/src/main/java/io/smallrye/common/ref/References.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,16 @@ static ReferenceQueue<Object> getReaperQueue() {
if (isBuildTime()) {
// do nothing (class should be reinitialized)
} else {
final PrivilegedAction<Void> action = () -> startThreadAction(1);
final PrivilegedAction<Void> action = new PrivilegedAction<>() {
@Override
public Void run() {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
}
};
Comment on lines +34 to +43
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final PrivilegedAction<Void> action = new PrivilegedAction<>() {
@Override
public Void run() {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
}
};
final PrivilegedAction<Void> action = () -> {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #1");
thr.setDaemon(true);
thr.start();
return null;
};

doPrivileged(action);
}
}
Expand All @@ -44,14 +53,6 @@ private static boolean isBuildTime() {
}
}

private static Void startThreadAction(int id) {
final ReaperThread thr = new ReaperThread();
thr.setName("Reference Reaper #" + id);
thr.setDaemon(true);
thr.start();
return null;
}

public void run() {
for (;;)
try {
Expand Down