Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid octal 0 in protocol test #1098

Merged
merged 1 commit into from
Dec 5, 2023
Merged

avoid octal 0 in protocol test #1098

merged 1 commit into from
Dec 5, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Dec 5, 2023

when the number is 0, we get 0000 in codegen which is an octal and not a normal integer

@kuhe kuhe requested review from a team as code owners December 5, 2023 17:50
@kuhe kuhe requested a review from AndrewFossAWS December 5, 2023 17:50
@kuhe kuhe merged commit 43d4bfb into smithy-lang:main Dec 5, 2023
@kuhe kuhe deleted the fix/number-protocol-test branch December 5, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@syall syall syall approved these changes

@AndrewFossAWS AndrewFossAWS Awaiting requested review from AndrewFossAWS AndrewFossAWS was automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuhe @trivikr @syall