Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid octal 0 in protocol test #1098

Merged
merged 1 commit into from
Dec 5, 2023
Merged

avoid octal 0 in protocol test #1098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...en/src/main/java/software/amazon/smithy/typescript/codegen/HttpProtocolTestGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,9 +1229,9 @@ public Void nullNode(NullNode node) {
@Override
public Void numberNode(NumberNode node) {
// Handle timestamps needing to be converted from numbers to their input type of Date.
// Also handle that a Date in TS takes milliseconds, so add 000 to the end.
// Also handle that a Date in TS takes milliseconds, so add * 1000 to the end.
if (workingShape.isTimestampShape()) {
writer.write("new Date($L000),", node.getValue());
writer.write("new Date($L * 1000),", node.getValue());
} else {
writer.write("$L,", node.getValue().toString());
}
Expand Down