fix: Fix snakedeploy hanging forever

[fxwiegand]

This PR fixes #63 by adding -y to the env remove calls. It seems like the conda frontend is waiting for user input and therefore taking forever.

Summary by CodeRabbit

• New Features

  • Enhanced the environment removal process by adding automatic confirmation, streamlining user experience.

• Bug Fixes

  • Resolved issues related to user prompts during environment removal, making it non-interactive.

[coderabbitai]

Walkthrough

The changes in this pull request modify the snakedeploy/conda.py file, specifically the CondaEnvProcessor class. The modifications involve adding the -y flag to exec_conda calls in the get_pkg_versions and update_pinning methods, enabling automatic confirmation for removing conda environments. This adjustment eliminates the need for user interaction during environment removal, ensuring a smoother execution flow. The overall structure and logic of the methods remain unchanged, focusing solely on enhancing the command execution process.

Changes

File	Change Summary
snakedeploy/conda.py	Added -y flag to exec_conda calls in get_pkg_versions and update_pinning methods to enable automatic confirmation for environment removal.

Assessment against linked issues

Objective	Addressed	Explanation
Modify exec_conda calls to prevent hanging during removal (#63)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

snakedeploy/conda.py (1)

295-295: LGTM: Consistent addition of -y flag.

The addition of the -y flag to the env remove command in the update_pinning method is consistent with the earlier change and contributes to resolving the hanging issue.

For improved consistency and maintainability, consider extracting the env remove command with the -y flag into a separate method within the CondaEnvProcessor class. This would centralize the logic and make future updates easier.

Here's a suggested implementation:

def remove_env(self, prefix):
    return self.exec_conda(f"env remove --prefix {prefix} -y")

# Then use it in both methods:
self.remove_env(tmpdir)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 07f2876 and 7f1054e.

📒 Files selected for processing (1)

• snakedeploy/conda.py (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

snakedeploy/conda.py (1)

Pattern **/*.py: Do not try to improve formatting.
Do not suggest type annotations for functions that are defined inside of functions or methods.
Do not suggest type annotation of the self argument of methods.
Do not suggest type annotation of the cls argument of classmethods.
Do not suggest return type annotation if a function or method does not contain a return statement.

🔇 Additional comments (2)

snakedeploy/conda.py (2)

196-196: LGTM: Addition of -y flag addresses the hanging issue.

The addition of the -y flag to the env remove command is an excellent solution to prevent the process from hanging while waiting for user input. This change directly addresses the issue described in #63 and aligns perfectly with the PR objectives.

---

Line range hint 1-395: Summary: PR successfully addresses the hanging issue.

The changes made in this PR effectively resolve the issue of snakedeploy pin-conda-envs hanging indefinitely, as described in issue #63. The addition of the -y flag to the env remove commands in both the get_pkg_versions and update_pinning methods ensures that the process doesn't wait for user input, allowing it to complete successfully.

These modifications align perfectly with the PR objectives and provide a straightforward solution to the problem. The changes are minimal and focused, maintaining the overall structure and logic of the CondaEnvProcessor class.

A minor suggestion has been made to improve code maintainability by extracting the env remove command into a separate method. This would centralize the logic and make future updates easier, but it's not critical for the current fix.

Overall, this PR successfully addresses the reported issue and improves the functionality of the snakedeploy tool.