-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-stage programming model with K-means, EM, LinearReg, and LogisticReg #19
Conversation
import org.apache.reef.tang.annotations.Name; | ||
|
||
/** | ||
* Information of a stage, which corresponds to a BSP algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an init stage a BSP algorithm? This sounds strange.
Later we have an asynchronous execution engine, we need to separate out the BSP-specific part from the general part.
@kijungshin @jsjason The code looks nicer than before. I left non-trivial amount of comments. Let's address the ones you can do quickly and merge this gigantic pull request ASAP. |
I removed unnecessary empty lines in every code according to the sun java coding convention. |
1) Tasks log more detailed information 2) reduce the dependency between the group communication service and the data loading service 3) reduce the number of fields using Optional
@jsjason @kijungshin If you agree that minor comments are addressed and major comments are registered as issues, please merge this pull request. This has been long overdue. |
@bgchun We agree that this is taking much longer than expected. Although @kijungshin has addressed most of the comments, there is still a few more he'd like to address; we decided to create a separate issue regarding the remaining comments, since almost all of them are about lacking explanations, renaming classes, etc. We'll get the job done shortly. |
All comments have been either addressed or marked as a separate issue. I'll merge this. |
Multi-stage programming model with K-means, EM, LinearReg, and LogisticReg
Related issues: #14, #16 , #17
Other algorithmic improvements:
Result of the correctness test: