[Simulation.Core] BaseMechanicalVisitor: Deprecate rootData #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: status to review
|
[ci-build][with-all-tests] |
hugtalbot
approved these changes
Dec 13, 2023
bakpaul
approved these changes
Dec 13, 2023
hugtalbot
added
pr: status ready
alxbilger
requested changes
Dec 13, 2023
… (typo) Co-authored-by: Alex Bilger <[email protected]>
fredroy
force-pushed
the
remove_simucore_nodedata
branch
from
2fed67b to
0edc969
Compare
fredroy
added a commit
to fredroy/sofa
that referenced
this pull request
Dec 21, 2023
…mework#4350) * remove ref to nodedata * add compat * Update Sofa/framework/Simulation/Core/src/sofa/simulation/config.h.in (typo) Co-authored-by: Alex Bilger <[email protected]> --------- Co-authored-by: Alex Bilger <[email protected]>
hugtalbot
pushed a commit
to hugtalbot/sofa
that referenced
this pull request
Jan 16, 2024
…mework#4350) * remove ref to nodedata * add compat * Update Sofa/framework/Simulation/Core/src/sofa/simulation/config.h.in (typo) Co-authored-by: Alex Bilger <[email protected]> --------- Co-authored-by: Alex Bilger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only used if a "LocalStorage" stack was provided but #4327 showed that it was not used actually.
(and #4328 showed it was used it in a wrong way)
So this PR makes all the related stuff (nodedata member, readNodeData and writeNodeData) non-functional at all
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if