-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Topology.Container.Dynamic] Add class TriangleSubdividers to store methods to subdivide a triangle in differents configurations #4747
Merged
bakpaul
merged 28 commits into
sofa-framework:master
from
epernod:inf_2024_11_triangleSubdividers
Jan 22, 2025
Merged
[Topology.Container.Dynamic] Add class TriangleSubdividers to store methods to subdivide a triangle in differents configurations #4747
bakpaul
merged 28 commits into
sofa-framework:master
from
epernod:inf_2024_11_triangleSubdividers
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epernod
added
pr: status to review
To notify reviewers to review this pull-request
pr: new feature
Implement a new feature
labels
May 20, 2024
[ci-build][with-all-tests] |
fredroy
added
pr: status wip
Development in the pull-request is still in progress
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jun 19, 2024
epernod
force-pushed
the
inf_2024_11_triangleSubdividers
branch
from
October 28, 2024 09:49
e81435f
to
ca988ab
Compare
epernod
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Jan 2, 2025
I definitely need a refresh on this but the CI says yes |
hugtalbot
reviewed
Jan 8, 2025
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
hugtalbot
reviewed
Jan 18, 2025
...nt/Topology/Container/Dynamic/src/sofa/component/topology/container/dynamic/PointModifiers.h
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
...logy/Container/Dynamic/src/sofa/component/topology/container/dynamic/TriangleSubdividers.cpp
Show resolved
Hide resolved
bakpaul
approved these changes
Jan 22, 2025
bakpaul
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
Jan 22, 2025
…the triangles positions and use real area as barycoef
… TriangleSubdivider
… confusion with TriangleSetTopologyModifier
…d testSubdivider_2Node
Co-authored-by: Hugo <[email protected]>
fredroy
force-pushed
the
inf_2024_11_triangleSubdividers
branch
from
January 22, 2025 14:05
43e5a82
to
b56078c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr: new feature
Implement a new feature
pr: status ready
Approved a pull-request, ready to be squashed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add utility class for
TriangleSetTopologyModifier
component.The class TriangleSubdivider allows to split triangle following 5 possible scenarios to subdivide a triangle.
Those subdividers will be used in a new version of Triangle incision in
TriangleSetGeometryAlgorithms
to come in futures PR.Examples of use can be found in Tearing Plugin in PR InfinyTech3D/Tearing#50 and InfinyTech3D/Tearing#51
Some benchmarks scenes have been introduced in those PR on several triangles configuration at start:
1Node
subdivision (1 Node inside the triangle)1Edge
subdivision (1 Node on 1 edge of the triangle)2Edge
subdivision (1 Node on 2 edges of the triangle)3Edge
subdivision (1 Node on 3 edges of the triangle)2Node
subdivision (1 Node on 1 edges of the triangle and 1 Node inside the triangle)Tests have been added for:
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if