[Base] Fix a minor bug related to the printing of info message while parsing & minor upgrade to c++11 #5191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parsing Parsing emits some messages with msg_info(). But this one is controlled by the printLog data field. The consequence is that every fields parsed before the "printLog" one are not reporting messages properly. To fix it we need to process the printLog one before any other so there is a consistent result.
damienmarchal
added
pr: fix
alxbilger
approved these changes
Jan 6, 2025
hugtalbot
reviewed
Jan 6, 2025
bakpaul
changed the title
bakpaul
removed
the
issue: bug (minor)
|
[ci-build][with-all-tests] |
bakpaul
reviewed
Jan 7, 2025
Co-authored-by: Paul Baksic <[email protected]>
bakpaul
approved these changes
Jan 9, 2025
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base::parse() emits some messages with msg_info().
But msg_info() is controlled by the printLog data field. The consequence is that every fields parsed before the "printLog" one are not reporting messages properly.
To fix it we need to process the printLog one before any other so there is a consistent result.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if