[Core] No longer support links to Node in Links #5223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a path is given to a Link, this path can reference a Node. However, Link are made to reference components. There is an implicit search of the right path based on a path to a Node. It allows to write something like
<RigidMapping input="@../" output="@./" />
.IMO, the input and output are not clear in this example. I prefer to explicit the path to the object. That is why I removed the implicit search.
The consequence is that is no longer possible to write
<RigidMapping/>
(without specifyinginput
andoutput
), because implicitlyinput
was equal to@../
, andoutput
was equal to@./
if they were not specified.That is why it may break some scenes and force to explicit some links.
I also applied changes on mappings to better guide the user.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if