Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] No longer support links to Node in Links #5223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxbilger
Copy link
Contributor

When a path is given to a Link, this path can reference a Node. However, Link are made to reference components. There is an implicit search of the right path based on a path to a Node. It allows to write something like <RigidMapping input="@../" output="@./" />.
IMO, the input and output are not clear in this example. I prefer to explicit the path to the object. That is why I removed the implicit search.
The consequence is that is no longer possible to write <RigidMapping/> (without specifying input and output), because implicitly input was equal to @../, and output was equal to @./ if they were not specified.
That is why it may break some scenes and force to explicit some links.

I also applied changes on mappings to better guide the user.


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added the pr: status to review To notify reviewers to review this pull-request label Jan 15, 2025
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests]

@hugtalbot hugtalbot added the pr: clean Cleaning the code label Jan 16, 2025
@bakpaul bakpaul added the pr: breaking Change possibly inducing a compilation error label Jan 20, 2025
@bakpaul bakpaul added pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now. and removed pr: status to review To notify reviewers to review this pull-request labels Jan 29, 2025
@hugtalbot hugtalbot added the pr: experimental Demonstrate an experimental feature label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: clean Cleaning the code pr: experimental Demonstrate an experimental feature pr: status postponed To keep in mind that this PR was interesting but no one has time to make it mergeable now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants