Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playback] Remove deprecated macro #5231

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Jan 21, 2025

Note: the macro SOFA_COMPONENT_PLAYBACK_HAVE_ZLIB is not necessary as Zlib is required in the CMakeLists.txt, making the variable SOFA_COMPONENT_PLAYBACK_HAVE_ZLIB always true -> issue #5232


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jan 21, 2025
Copy link
Contributor

@hugtalbot hugtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Paul, when ZLIB is found in a find_package of a module it creates automatically the symbol: SOFA_COMPONENT_PLAYBACK_HAVE_ZLIB

If my understanding is correct, I approve 👍

@fredroy
Copy link
Contributor

fredroy commented Jan 21, 2025

According to Paul, when ZLIB is found in a find_package of a module it creates automatically the symbol: SOFA_COMPONENT_PLAYBACK_HAVE_ZLIB

If my understanding is correct, I approve 👍

Correct but little detail, it is not find_package() but our own macro sofa_find_package() who does it

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 29, 2025
@hugtalbot hugtalbot merged commit 38c295d into sofa-framework:master Jan 29, 2025
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants