Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SceneUtility] Remove *AliasComponent #5241

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SceneUtility] Remove *AliasComponent #5241

wants to merge 1 commit into from

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Jan 23, 2025 •
edited
Loading

Further discussions in #5183 , remove MakeAliasComponent and MakeDataAliasComponent since we now have a policy for aliases and a lifecycle for renaming

I suggest not compat layer since these are utility mostly for us

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jan 23, 2025
alxbilger
alxbilger reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if you don't implement a compatibility, you can add an entry in the ComponentChange, no?

hugtalbot
hugtalbot commented Jan 29, 2025
View reviewed changes
Sofa/framework/Helper/src/sofa/helper/ComponentChange.cpp
Comment on lines -130 to -131
{ "MakeAliasComponent", Moved("v22.06", "SofaBaseUtils", Sofa.Component.SceneUtility) },
{ "MakeDataAliasComponent", Moved("v22.06", "SofaBaseUtils", Sofa.Component.SceneUtility) },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's make it removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxbilger alxbilger alxbilger left review comments

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugtalbot @alxbilger