-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry
field to dependency schema
#757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2023
Merged
maciektr
approved these changes
Oct 5, 2023
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 08:10
09584d9
to
80af4a7
Compare
mkaput
force-pushed
the
spr/main/3dd75c42
branch
2 times, most recently
from
October 6, 2023 08:58
2898a1c
to
686bd81
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 08:58
80af4a7
to
5960456
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 09:27
5960456
to
e8b8c7b
Compare
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 09:27
686bd81
to
d84eb6e
Compare
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 09:57
d84eb6e
to
d5b19d1
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 09:57
e8b8c7b
to
576f803
Compare
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 10:41
d5b19d1
to
d257b16
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 10:41
576f803
to
2e2f96f
Compare
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 11:30
d257b16
to
9ea3f37
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 11:30
2e2f96f
to
0088929
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
This PR makes `scarb package` check for `.scarbignore` files when determining package source files set. This is a trivial addition thanks to features of the `ignore` crate. Supporting this file is effectively a similar feature to the include/exclude fields of Cargo (https://doc.rust-lang.org/cargo/reference/manifest.html#the-exclude-and-include-fields). This PR fixes #644 then, as we do not want to create multiple ways of achieving the same thing. --- **Stack**: - #758 - #757 - #748 - #746 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 12:02
9ea3f37
to
86b5a84
Compare
mkaput
force-pushed
the
spr/main/42d7d77a
branch
from
October 6, 2023 12:02
0088929
to
53f898c
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
… to avoid cloning it (#748) **Stack**: - #758 - #757 - #748 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
commit-id:3dd75c42
mkaput
force-pushed
the
spr/main/3dd75c42
branch
from
October 6, 2023 18:15
86b5a84
to
7157976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
todo!
calls in packaging logic #758registry
field to dependency schema #757 ⬅