-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check archive filenames #697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2023
This was referenced Sep 25, 2023
6adf54e
to
116a7cc
Compare
116a7cc
to
4dbf0a5
Compare
4dbf0a5
to
ea97649
Compare
ea97649
to
f17a272
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
1. There were no reasons to disallow `[[target.lib]]`. 2. On the other hand, it would be cool to expect target names to have package-name-style validation. --- **Stack**: - #697 - #710 - #675 - #657 - #646 - #712 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
d516f3e
to
c5b93fb
Compare
afbe50f
to
db67b25
Compare
c5b93fb
to
3688e71
Compare
db67b25
to
a0fb8fa
Compare
89a843c
to
da7f64a
Compare
6eeaa3d
to
cd7ca4f
Compare
szymmis
approved these changes
Oct 3, 2023
f307c4c
to
4d7fe8e
Compare
maciektr
approved these changes
Oct 3, 2023
This was referenced Oct 3, 2023
0098b47
to
fa72c76
Compare
4d7fe8e
to
0d1ad86
Compare
fa72c76
to
e387ec9
Compare
0d1ad86
to
4b954a5
Compare
4b954a5
to
23ca313
Compare
e387ec9
to
f08f9bd
Compare
23ca313
to
4a795d7
Compare
f08f9bd
to
473cac7
Compare
4a795d7
to
80d3423
Compare
80d3423
to
2d29ee7
Compare
2f2938d
to
10b1e19
Compare
commit-id:1b4d23da
2d29ee7
to
24329a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
todo!
calls in packaging logic #758registry
field to dependency schema #757DetailedTomlDependency
into aBox
and useCow
to avoid cloning it #748.scarbignore
files when packaging #746