Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Apple Vision Pro #223

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

simlay
Copy link
Contributor

@simlay simlay commented Apr 9, 2024

Apple Vision Pro support was added as a tier 3 target to rust in rust-lang/rust#121419 with target_os of visionos.

Depends on:

@simlay simlay mentioned this pull request Apr 9, 2024
.travis.sh Outdated Show resolved Hide resolved
@simlay simlay force-pushed the add-support-for-vision-pro-simulator branch from e08c2f4 to 615428b Compare May 2, 2024 18:59
Comment on lines +99 to +101
xcrun simctl list devices vision
system_profiler SPDeveloperToolsDataType
xcodebuild -showsdks
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking into this a bit, the current default xcode used on the macOS-14 runner is 15.0.1. The visionOS simulator requires xcode 15.2+ and I don't feel like adding in the logic to switch between xcode versions in this CI.

Also, actions/runner-images#9511

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this still applies. I can either remove visionOS from the CI matrix or we can wait until the macos runner updates the default xcode. I'm not sure what the xcode versioning policy is (if there is one) on github runners.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:

if [ -z "${GITHUB_ACTIONS}" ]; then
   # These steps fail in GitHub Actions due to https://...
fi

@simlay simlay marked this pull request as ready for review May 21, 2024 16:15
Copy link

@briansmith briansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. I didn't test it because I don't have a mac available to me right now. Some comments....

@@ -45,6 +45,9 @@ jobs:
matrix:
os: [ macOS-13, macOS-14 ]
sim: [ tvOS, watchOS ]
include:
- os: macos-14
sim: visionOS

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add here:

            xcode_version: 15.2

then before you run the shell script you can add a step:

      - if: ${{ matrix.xcode_version != '' }}
        run: sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode_version }}.app

This is what I've done in my CI.

Comment on lines +99 to +101
xcrun simctl list devices vision
system_profiler SPDeveloperToolsDataType
xcodebuild -showsdks

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:

if [ -z "${GITHUB_ACTIONS}" ]; then
   # These steps fail in GitHub Actions due to https://...
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants