Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matrix in CI for third tier apple simulators #228

Merged
merged 1 commit into from
May 2, 2024

Conversation

simlay
Copy link
Contributor

@simlay simlay commented May 2, 2024

Over in #223 (comment), it was suggested to move some of the apple simulator targets to be in a github action matrix.

@simlay simlay mentioned this pull request May 2, 2024
1 task
@fredszaq
Copy link
Collaborator

fredszaq commented May 2, 2024

Nice ! gotta love a faster ci !

@simlay simlay force-pushed the use-matrix-for-apple-simulator-ci branch from d188cf9 to 3acb441 Compare May 2, 2024 16:03
@simlay
Copy link
Contributor Author

simlay commented May 2, 2024

Nice ! gotta love a faster ci !

Not the most scientific comparison but looking at the last week of CI:

image
vs this pr:
image

Went from ~25 minutes to ~16 minutes.

@fredszaq fredszaq merged commit c625f69 into sonos:main May 2, 2024
10 checks passed
@simlay simlay deleted the use-matrix-for-apple-simulator-ci branch May 2, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants