Final pull request before next update #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A few more tweaks to the game strings * Translated and finalized the Agsharp strings * Fixed the wrong culture keys in all 4 po files
Added missing English translation for the "Loading..." string when loading a recording into the built-in player.
* Fixed the last remaining errors and typos, including in-game strings. * Rephrased some sentences to sound more natural and/or to better explain the concept, including in-game strings. * Made sure all terms, like skill names, are consistent with the in-game strings. * Reworded everything to address the player informally in the second person of singular, for consistency with in-game strings. I now consider the entire translation to be finalized, tested and ready for production.
* Latest versions of the translated docs from my fork didn't seem to make it into the game update, even though I included them in the pull request before 1.2.3. Please merge this commit in a future patch. Not urgent.
Made sure all Ball Bouncer, Agsharp, changelog and readme strings are up-to-date, consistent, correct and the way I want them to be before the next major update.
|
Validation and conversion completed without errors, let's wait for the review team. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, all the translations are finally properly finalized, up-to-date, consistent and correct. This is my last pull request before the next update.