Remove the default build_type for packages with the default CMake builds #41163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spackbot-app
bot
requested review from
alalazo,
AlexanderRichert-NOAA,
climbfuji,
edwardhartnett,
haampie,
Hang-Lei-NOAA,
johnwparent,
KineticTheory and
t-brown
|
@BenjaminTJohnson can you review this PR? This PR modifies the following package(s), for which you are listed as a maintainer:
|
alalazo
requested changes
Nov 20, 2023
| @@ -54,12 +54,6 @@ def url_for_version(self, version): | |||
| with when("build_system=cmake"): | |||
| variant("chrpath", default=False, description="Use chrpath for deployment") | |||
| variant("strip", default=False, description="Use binutils strip for deployment") | |||
| variant( | |||
| "build_type", | |||
| default="RelWithDebInfo", | |||
KineticTheory
approved these changes
Nov 21, 2023
haampie
approved these changes
Nov 27, 2023
alalazo
approved these changes
Nov 27, 2023
This was referenced Nov 29, 2023
climbfuji
pushed a commit
to climbfuji/spack
that referenced
this pull request
Dec 19, 2023
…41163) Co-authored-by: jmcarcell <[email protected]>
3 tasks
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 31, 2024
…41163) Co-authored-by: jmcarcell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
build_typebe configured by the user or the default (currentlyRelease) without having different default settings in each package.I have only changed the packages with the four default cases, but there are several candidate packages that only have a subset of the four that probably also don't need to have specified the
build_type. For packages with different options, removing this may lead to problems if a certain type of build can't be done, as that would fail now at concretization time and without this block it would fail at build time.