Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FATAL] Fix #123, #126, fix synchronized reviews, add translation in timetable #128

Merged
merged 7 commits into from
Aug 22, 2023

Conversation

hoosong0235
Copy link
Contributor

No description provided.

@hoosong0235 hoosong0235 added the bug Something isn't working label Aug 3, 2023
@hoosong0235 hoosong0235 self-assigned this Aug 3, 2023
@github-actions github-actions bot added the size/m label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #128 (daa3985) into main (022ebab) will decrease coverage by 5.23%.
The diff coverage is 16.82%.

❗ Current head daa3985 differs from pull request most recent head 11fec86. Consider uploading reports for the commit 11fec86 to get more accurate results

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   32.65%   27.42%   -5.23%     
==========================================
  Files          79       80       +1     
  Lines        4683     4733      +50     
==========================================
- Hits         1529     1298     -231     
- Misses       3154     3435     +281     
Files Changed Coverage Δ
lib/main.dart 0.00% <0.00%> (ø)
lib/pages/lecture_detail_page.dart 4.81% <0.00%> (-2.00%) ⬇️
lib/pages/main_page.dart 0.00% <ø> (ø)
lib/pages/review_page.dart 0.00% <0.00%> (ø)
lib/pages/timetable_page.dart 4.16% <0.00%> (+0.19%) ⬆️
lib/providers/hall_of_fame_model.dart 0.00% <0.00%> (ø)
lib/providers/latest_reviews_model.dart 0.00% <0.00%> (ø)
lib/utils/build_page_route.dart 0.00% <0.00%> (ø)
lib/widgets/lecture_group_block.dart 0.00% <0.00%> (-87.18%) ⬇️
lib/widgets/lecture_group_block_row.dart 0.00% <0.00%> (-58.34%) ⬇️
... and 3 more

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoosong0235 hoosong0235 changed the title [FATAL] Fix@reviews syncronize [FATAL] fix reviews syncronize, timetable translate Aug 4, 2023
@hoosong0235
Copy link
Contributor Author

1 2 3
before Screenshot_1691302748 Screenshot_1691302757 Screenshot_1691302761
after Screenshot_1691302585 Screenshot_1691302593 Screenshot_1691302603

@hoosong0235 hoosong0235 changed the title [FATAL] fix reviews syncronize, timetable translate [FATAL] fix reviews syncronize, timetable translate, add Language Setting Aug 10, 2023
@hoosong0235 hoosong0235 linked an issue Aug 10, 2023 that may be closed by this pull request
@hoosong0235
Copy link
Contributor Author

untitled.webm

@sboh1214 sboh1214 force-pushed the fix@reviews-syncronize branch 4 times, most recently from 2f9aef8 to 09c80d0 Compare August 20, 2023 18:01
@sboh1214 sboh1214 removed a link to an issue Aug 20, 2023
@sboh1214 sboh1214 changed the title [FATAL] fix reviews syncronize, timetable translate, add Language Setting [FATAL] Fix #123, #126, fix synchronized reviews, add translation in timetable Aug 20, 2023
@sboh1214 sboh1214 merged commit d5bd48d into main Aug 22, 2023
7 of 8 checks passed
@sboh1214 sboh1214 deleted the fix@reviews-syncronize branch August 22, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/m
Projects
None yet
3 participants