Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add series data entry feature #4804

Merged
merged 72 commits into from
Jul 15, 2024
Merged

Add series data entry feature #4804

merged 72 commits into from
Jul 15, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Apr 17, 2024

Fixes #545

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Create a new CO
  • Save
  • Go in the form meta, check the box "Show Bulk Carry Forward count"
  • Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
  • Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
  • Go back to the CO form
  • Enter the amount you want to bulk carry
  • Click on carry forward
  • Verify that a new RS is created
  • Verify that the new RS has, as a title, the cat number range
  • Verify once the new RS is created, it opens it

@CarolineDenis CarolineDenis changed the title Issue 545 Add series data entry feature Apr 17, 2024
@CarolineDenis CarolineDenis requested a review from sharadsw May 20, 2024 14:32
@CarolineDenis CarolineDenis added this to the 7.9.x milestone May 20, 2024
Copy link
Contributor

@sharadsw sharadsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Only making some optional suggestions

@CarolineDenis CarolineDenis modified the milestones: 7.9.x, 7.9.7 May 23, 2024
@CarolineDenis CarolineDenis requested a review from a team May 23, 2024 20:05
@acwhite211 acwhite211 self-requested a review July 8, 2024 18:35
@melton-jason melton-jason self-requested a review July 8, 2024 19:10
@Areyes42 Areyes42 self-requested a review July 9, 2024 16:37
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Create a new CO
  • Save
  • Go in the form meta, check the box "Show Bulk Carry Forward count"
  • Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
  • Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
  • Go back to the CO form
  • Enter the amount you want to bulk carry
  • Click on carry forward
  • Verify that a new RS is created
  • Verify that the new RS has, as a title, the cat number range
  • Verify once the new RS is created, it opens it

I tested this PR yesterday and it was working fine. It's now throwing a TypeError when trying to bulk carry. Tested on multiple COs and DBs.

Specify 7 Crash Report - 2024-07-09T16_28_03.361Z.txt

Screen.Recording.2024-07-09.at.11.27.28.AM.mov

@CarolineDenis CarolineDenis requested a review from Areyes42 July 9, 2024 17:33
Copy link
Contributor

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Create a new CO
  • Save
  • Go in the form meta, check the box "Show Bulk Carry Forward count"
  • Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
  • Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
  • Go back to the CO form
  • Enter the amount you want to bulk carry
  • Click on carry forward
  • Verify that a new RS is created
  • Verify that the new RS has, as a title, the cat number range
  • Verify once the new RS is created, it opens it

Retested, everything looks good!

@CarolineDenis CarolineDenis dismissed stale reviews from melton-jason and realVinayak July 15, 2024 13:39

fixed

@CarolineDenis CarolineDenis merged commit 4c32cd4 into production Jul 15, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-545 branch July 15, 2024 13:42
@grantfitzsimmons
Copy link
Member

Need to now implement #4952

@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Series data entry