-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add series data entry feature #4804
Conversation
Triggered by 0680b87 on branch refs/heads/issue-545
ffa931c
to
5cf1c90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only making some optional suggestions
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSet.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Create a new CO
- Save
- Go in the form meta, check the box "Show Bulk Carry Forward count"
- Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
- Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
- Go back to the CO form
- Enter the amount you want to bulk carry
- Click on carry forward
- Verify that a new RS is created
- Verify that the new RS has, as a title, the cat number range
- Verify once the new RS is created, it opens it
I tested this PR yesterday and it was working fine. It's now throwing a TypeError when trying to bulk carry. Tested on multiple COs and DBs.
Specify 7 Crash Report - 2024-07-09T16_28_03.361Z.txt
Screen.Recording.2024-07-09.at.11.27.28.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
- Create a new CO
- Save
- Go in the form meta, check the box "Show Bulk Carry Forward count"
- Verify the box "Show Bulk Carry Forward count" is displayed only when carry forward is checked
- Verify that the Bulk amount input is not displayed on the form if carry forward or "Show Bulk Carry Forward count" is not checked in the form meta
- Go back to the CO form
- Enter the amount you want to bulk carry
- Click on carry forward
- Verify that a new RS is created
- Verify that the new RS has, as a title, the cat number range
- Verify once the new RS is created, it opens it
Retested, everything looks good!
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSet.tsx
Outdated
Show resolved
Hide resolved
Need to now implement #4952 |
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
Fixes #545
Checklist
and self-explanatory (or properly documented)
Testing instructions