-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add series tool in query builder #4952
base: production
Are you sure you want to change the base?
Conversation
This is the second component of #4804 |
FYI: backend, after #4929, will support server-side record cloning |
@specify/ux-testing It would be great if you could use the same database with Specify 6 to make sure the results are consistent between versions. If they are not, we should try and understand what the difference is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Issues
1. Any operator on catalogNumber does not work.
Screen.Recording.2025-02-26.at.9.45.20.AM.mov
- Ordering does not work with Series checked.
UPDATE: Will not be included in this PR. Written up issue: Ordering does not work with Series checked #6291
Screen.Recording.2025-02-26.at.8.50.28.AM.mov
3. "Error: Returned 328 results, when expected at most 40"
Specify 7 Crash Report - 2025-02-26T15_07_29.529Z.txt
"Error: Returned 143 results, when expected at most 40":
Specify 7 Crash Report - 2025-02-26T15_20_36.183Z.txt
I reproduced this error with this query:
4. - [ ] Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Can't really test this on fields from the Tip because of the error from issue 3.
- Also noticed that the results show up as "Results: (1)" for the query
catalogNumber -> Any
- is this expected?

Also I tested locally because on the test panel I get this error upon opening the instance:
Specify 7 Crash Report - 2025-02-26T15_13_30.978Z.txt

@pashiav for your comment: It will not be addressed in this pr. Could you create a new issue and link it in your comment please? |
I fixed the series logic for alphanumeric cat nums. I was able to get the sorting of the series ranged cat nums working as well 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- verify series checkbox is present only when Cat num is one of the field
- verify Distinct is read only
- Verify you can check Distinct and that Series become readonly
- Verify that all the records that have the same data for each field in your query and that have consecutive cat num are group together
- Verify that the consecutive cat numbers are displayed as a range
Adding determinations, modified by agent, or age to the query throws an error
02-28_14.24.mp4
Specify 7 Crash Report - 2025-02-28T20_47_01.573Z.txt
Results showing incorrect count
02-28_14.32.mp4
If you check series and then delete the Cat # from the query and try to query you get an error
Fixes #2000
Fixes #6166
Checklist
and self-explanatory (or properly documented)
Testing instructions
Tips:
With Series

Without Series
