Ensure latest version source

[ofek]

Address #4341 (comment)

[ofek]

Should be good to merge 👍

[squidfunk]

Thanks for the PR. I'm discovering more and more that the ecosystem doesn't seem to be ready for the switch, e.g. PyPI stats can't resolve author, license, etc. anymore: https://pypistats.org/packages/mkdocs-material

I'm not sure this is ready for primetime.

[ofek]

Hmm, cc @hugovk

[hugovk]

https://pypi.org/pypi/mkdocs-material/json contains:

{
"info": {
"author": "",
...
"license": "",
...

I see https://github.com/squidfunk/mkdocs-material/blob/master/pyproject.toml also contains no license or authors under [project].

Compare:

license = {text = "MIT"}
authors = [{name = "Hugo van Kemenade"}]

• https://github.com/hugovk/pepotron/blob/885bd0b111202976b04dbac4950ea057bf706aa3/pyproject.toml#L17-L18

And they can be see at:

• https://pypi.org/project/pepotron/
• https://pypistats.org/packages/pepotron
• https://pypi.org/pypi/pepotron/json

{
"info": {
"author": "Hugo van Kemenade",
...
"license": "MIT",
...

Should they be added here?

[ofek]

1. So for the license see Revert "Declare license file in packaging tutorial" pypa/packaging.python.org#1143, basically until PyPI supports PEP 639 one must use classifiers
2. The author in wheel is Author-email: Martin Donath <[email protected]> which is also how setuptools works

Both show correctly here under Meta tab https://pypi.org/project/mkdocs-material/

[hugovk]

Looks like pypistats.org is just using ['info']['author'] and ['info']['license'] from the JSON:

https://github.com/crflynn/pypistats.org/blob/e44f3944da4f065005fc750d0ed86bd1b42a3f56/pypistats/templates/package.html#L31-L32

I suggest opening an issue at https://github.com/crflynn/pypistats.org/issues

(My https://github.com/hugovk/pypistats is a Python client using the pypistats.org API; I'm not a maintainer of pypistats.org.)

[squidfunk]

I'm considering this ready for merge then. PyPI stats is not critical, but it would be great if this could be solved and reported. I'm not very familiar with the Python packaging ecosystem, so I would be thankful if one of you could take this on.

[squidfunk]

So, as a temporary measure, couldn't we just add back all the information that was present in the setup.py before? This would at least fix the issues...

mkdocs-material/setup.py

Lines 40 to 78 in cccc214

	setup(
	name = "mkdocs-material",
	version = package["version"],
	url = package["homepage"],
	project_urls = {
	"Source": "https://github.com/squidfunk/mkdocs-material",
	},
	license = package["license"],
	description = package["description"],
	long_description = long_description,
	long_description_content_type = "text/markdown",
	author = package["author"]["name"],
	author_email = package["author"]["email"],
	keywords = package["keywords"],
	classifiers = [
	"Development Status :: 5 - Production/Stable",
	"Environment :: Web Environment",
	"License :: OSI Approved :: MIT License",
	"Programming Language :: JavaScript",
	"Programming Language :: Python",
	"Topic :: Documentation",
	"Topic :: Software Development :: Documentation",
	"Topic :: Text Processing :: Markup :: HTML"
	],
	packages = find_packages(exclude = ["src", "src.*"]),
	include_package_data = True,
	install_requires = install_requires,
	python_requires='>=3.7',
	entry_points = {
	"mkdocs.themes": [
	"material = material"
	],
	"mkdocs.plugins": [
	"search = material.plugins.search.plugin:SearchPlugin",
	"tags = material.plugins.tags.plugin:TagsPlugin"
	]
	},
	zip_safe = False
	)

[ofek]

That wouldn't fix it, here's the known issue pypi/warehouse#9400