Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

feat(consensus): add Vote message to proto #2131

Closed
wants to merge 1 commit into from
Closed

feat(consensus): add Vote message to proto #2131

wants to merge 1 commit into from

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Jun 20, 2024 •
edited by hkrasniker-starkware
Loading

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review June 20, 2024 09:42
@matan-starkware matan-starkware mentioned this pull request Jun 20, 2024
Closed
@matan-starkware
Copy link
Contributor Author

matan-starkware commented Jun 20, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite Graphite

@matan-starkware matan-starkware mentioned this pull request Jun 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jun 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (ba811ee) to head (bd4941c).

Files Patch % Lines
...rates/papyrus_protobuf/src/converters/consensus.rs 0.00% 41 Missing ⚠️
Additional details and impacted files 
@@                                  Coverage Diff                                   @@
##           06-19-feat_consensus_add_milestone_2_state_machine    #2131      +/-   ##
======================================================================================
- Coverage                                               65.40%   65.27%   -0.14%     
======================================================================================
  Files                                                     136      136              
  Lines                                                   17948    17986      +38     
  Branches                                                17948    17986      +38     
======================================================================================
+ Hits                                                    11739    11740       +1     
- Misses                                                   4924     4962      +38     
+ Partials                                                 1285     1284       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 899957f to a9f644f Compare June 20, 2024 11:04
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch 2 times, most recently from ee54b7d to 577f0e7 Compare June 20, 2024 14:25
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from a9f644f to b929d88 Compare June 23, 2024 10:29
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 577f0e7 to 3e5cbf7 Compare June 23, 2024 10:29
@matan-starkware matan-starkware mentioned this pull request Jun 23, 2024
Merged
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from b929d88 to 2a91981 Compare June 23, 2024 17:42
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 3e5cbf7 to 2feb83e Compare June 23, 2024 17:42
@matan-starkware matan-starkware mentioned this pull request Jun 23, 2024
Closed
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 2a91981 to f97fb66 Compare June 24, 2024 12:53
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 2feb83e to c9faca9 Compare June 24, 2024 12:53
@matan-starkware matan-starkware mentioned this pull request Jun 24, 2024
Merged
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from f97fb66 to f82c715 Compare June 24, 2024 13:01
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from c9faca9 to bc999da Compare June 24, 2024 13:02
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from f82c715 to 39b8589 Compare June 24, 2024 13:31
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch 2 times, most recently from d2380e5 to dcb34e4 Compare June 24, 2024 13:35
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 39b8589 to 6ff0c6c Compare June 24, 2024 14:16
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from dcb34e4 to 8efee4b Compare June 24, 2024 14:17
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 6ff0c6c to 1acaab2 Compare June 24, 2024 14:38
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 8efee4b to c7fe905 Compare June 24, 2024 14:38
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 1acaab2 to 3cb9609 Compare June 24, 2024 17:56
@matan-starkware matan-starkware mentioned this pull request Jun 24, 2024
Merged
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from c7fe905 to 041f6e7 Compare June 24, 2024 17:56
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from f1b24d1 to b052dfc Compare June 25, 2024 14:41
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 2418582 to 19c6e1a Compare June 25, 2024 14:41
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from b052dfc to ff907ac Compare June 25, 2024 14:56
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 19c6e1a to 668ca07 Compare June 25, 2024 14:56
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from ff907ac to 0c064b1 Compare June 25, 2024 17:24
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 668ca07 to 0c35291 Compare June 25, 2024 17:24
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 0c064b1 to a2a31b3 Compare June 26, 2024 06:49
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 0c35291 to c8bb9c8 Compare June 26, 2024 06:50
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from a2a31b3 to 737c2eb Compare June 26, 2024 07:11
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from c8bb9c8 to a1f8d86 Compare June 26, 2024 07:11
@matan-starkware matan-starkware mentioned this pull request Jun 26, 2024
Merged
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 737c2eb to b67d96f Compare June 26, 2024 07:22
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from a1f8d86 to aaa8d93 Compare June 26, 2024 07:22
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from b67d96f to 87b4ef5 Compare June 26, 2024 07:26
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from aaa8d93 to 559c068 Compare June 26, 2024 07:26
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 87b4ef5 to ffb58b1 Compare June 26, 2024 10:33
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 559c068 to 2682cce Compare June 26, 2024 10:33
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from ffb58b1 to add56d6 Compare June 26, 2024 14:47
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 2682cce to 1ffc77b Compare June 26, 2024 14:47
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from add56d6 to deff22c Compare June 26, 2024 18:04
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 1ffc77b to 61ef312 Compare June 26, 2024 18:04
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from deff22c to 8f79c12 Compare June 27, 2024 06:38
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 61ef312 to b5ba314 Compare June 27, 2024 06:38
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 8f79c12 to 9c46ea9 Compare June 27, 2024 08:25
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from b5ba314 to 0122c1b Compare June 27, 2024 08:25
@matan-starkware matan-starkware force-pushed the 06-19-feat_consensus_add_milestone_2_state_machine branch from 9c46ea9 to ba811ee Compare June 27, 2024 09:00
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 0122c1b to bd4941c Compare June 27, 2024 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dan-starkware dan-starkware Awaiting requested review from dan-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matan-starkware @asmaastarkware