Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

feat(consensus): add sequencing crates to some CI flows #2134

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

matan-starkware
Copy link
Contributor

@matan-starkware matan-starkware commented Jun 23, 2024

This change is Reviewable

@matan-starkware matan-starkware marked this pull request as ready for review June 23, 2024 10:29
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.97%. Comparing base (10ceb2a) to head (1726a9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
+ Coverage   65.93%   65.97%   +0.04%     
==========================================
  Files         135      135              
  Lines       17793    17793              
  Branches    17793    17793              
==========================================
+ Hits        11731    11739       +8     
+ Misses       4779     4769      -10     
- Partials     1283     1285       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 3e5cbf7 to 2feb83e Compare June 23, 2024 17:42
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from 2feb83e to c9faca9 Compare June 24, 2024 12:53
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from c9faca9 to bc999da Compare June 24, 2024 13:02
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from bc999da to d2380e5 Compare June 24, 2024 13:31
@matan-starkware matan-starkware force-pushed the matan/consensus_add_vote_proto branch from d2380e5 to dcb34e4 Compare June 24, 2024 13:35
@matan-starkware matan-starkware force-pushed the matan/consensus_ci branch 2 times, most recently from c219ba2 to e2811f3 Compare June 24, 2024 14:16
@matan-starkware matan-starkware changed the base branch from matan/consensus_add_vote_proto to matan/consensus_tracing June 24, 2024 14:16
@matan-starkware matan-starkware force-pushed the matan/consensus_tracing branch from a552685 to 5020790 Compare June 24, 2024 14:37
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

@matan-starkware matan-starkware force-pushed the matan/consensus_tracing branch from 5020790 to 9ee7c83 Compare June 25, 2024 12:29
@matan-starkware matan-starkware force-pushed the matan/consensus_ci branch 2 times, most recently from b57b840 to e27de04 Compare June 25, 2024 13:50
@matan-starkware matan-starkware force-pushed the matan/consensus_tracing branch from 9ee7c83 to 3d79e30 Compare June 25, 2024 14:40
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matan-starkware)


crates/sequencing/papyrus_block_builder/src/lib.rs line 55 at r4 (raw file):

            .expect("Failed to read storage")
            .get_block_transactions(block_number)
            .expect("Block missing in storage");
  1. Is it guaranteed that the block_number is in storage. If so please add this to the documentation.
  2. Try and phrase these messages with should. From option documentation

Code quote:

.expect("Block missing in storage");

crates/sequencing/papyrus_consensus/src/lib.rs line 4 at r4 (raw file):

// TODO(Matan): Add a description of the crate.
// TODO(Matan): fix #[allow(missing_docs)].
//! A consensus implementation for a [`Starknet`] node.

Consider adding instead
//! [`Starknet`]: https://starknet.io/

Code quote:

A consensus implementation for a [`Starknet`] node.

Base automatically changed from matan/consensus_tracing to main June 26, 2024 09:47
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)

Copy link
Contributor Author

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)


crates/sequencing/papyrus_consensus/src/lib.rs line 4 at r4 (raw file):

Previously, dan-starkware wrote…

Consider adding instead
//! [`Starknet`]: https://starknet.io/

Done.

@matan-starkware matan-starkware added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 9d1e7cc Jun 26, 2024
19 checks passed
@matan-starkware matan-starkware deleted the matan/consensus_ci branch June 26, 2024 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants