-
Notifications
You must be signed in to change notification settings - Fork 89
feat(consensus): add sequencing crates to some CI flows #2134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2134 +/- ##
==========================================
+ Coverage 65.93% 65.97% +0.04%
==========================================
Files 135 135
Lines 17793 17793
Branches 17793 17793
==========================================
+ Hits 11731 11739 +8
+ Misses 4779 4769 -10
- Partials 1283 1285 +2 ☔ View full report in Codecov by Sentry. |
ce9c7e3
to
ded02e7
Compare
3e5cbf7
to
2feb83e
Compare
ded02e7
to
2984b60
Compare
2feb83e
to
c9faca9
Compare
2984b60
to
2db0e06
Compare
c9faca9
to
bc999da
Compare
2db0e06
to
10e1d53
Compare
bc999da
to
d2380e5
Compare
10e1d53
to
f6d48bf
Compare
d2380e5
to
dcb34e4
Compare
c219ba2
to
e2811f3
Compare
a552685
to
5020790
Compare
e2811f3
to
24fb0e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
5020790
to
9ee7c83
Compare
b57b840
to
e27de04
Compare
9ee7c83
to
3d79e30
Compare
e27de04
to
a121a19
Compare
3d79e30
to
1bdc597
Compare
5a158c2
to
cf640ab
Compare
1bdc597
to
89f5ad9
Compare
cf640ab
to
43dac6f
Compare
89f5ad9
to
aff6ab1
Compare
43dac6f
to
cc184bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matan-starkware)
crates/sequencing/papyrus_block_builder/src/lib.rs
line 55 at r4 (raw file):
.expect("Failed to read storage") .get_block_transactions(block_number) .expect("Block missing in storage");
- Is it guaranteed that the
block_number
is in storage. If so please add this to the documentation. - Try and phrase these messages with
should
. From option documentation
Code quote:
.expect("Block missing in storage");
crates/sequencing/papyrus_consensus/src/lib.rs
line 4 at r4 (raw file):
// TODO(Matan): Add a description of the crate. // TODO(Matan): fix #[allow(missing_docs)]. //! A consensus implementation for a [`Starknet`] node.
Consider adding instead
//! [`Starknet`]: https://starknet.io/
Code quote:
A consensus implementation for a [`Starknet`] node.
cc184bb
to
268962a
Compare
268962a
to
1726a9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
crates/sequencing/papyrus_consensus/src/lib.rs
line 4 at r4 (raw file):
Previously, dan-starkware wrote…
Consider adding instead
//! [`Starknet`]: https://starknet.io/
Done.
This change is