Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move version_config out of api into main gateway src #833

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented Jul 11, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-transactions branch from 981cf92 to 537a674 Compare July 12, 2023 07:33
@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-version-config branch from 6389342 to b0fb60c Compare July 12, 2023 07:33
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #833 (5d7d39a) into main (4ede747) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   72.40%   72.20%   -0.21%     
==========================================
  Files          45       45              
  Lines        4367     4367              
  Branches     4367     4367              
==========================================
- Hits         3162     3153       -9     
- Misses        555      568      +13     
+ Partials      650      646       -4     
Impacted Files Coverage Δ
crates/papyrus_gateway/src/api/mod.rs 71.05% <ø> (ø)
crates/papyrus_gateway/src/lib.rs 68.51% <ø> (ø)
crates/papyrus_gateway/src/middleware.rs 80.76% <ø> (ø)
crates/papyrus_gateway/src/version_config.rs 50.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-transactions branch from 537a674 to 0d42931 Compare July 12, 2023 08:02
@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-version-config branch 2 times, most recently from e1069c2 to 8959ca3 Compare July 12, 2023 08:28
@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-transactions branch from ee067c8 to e9d3278 Compare July 12, 2023 09:02
@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-version-config branch from 8959ca3 to 9b7b466 Compare July 12, 2023 09:02
Base automatically changed from refactor-gateway-for-multiversion-implementation-transactions to main July 12, 2023 09:49
dan-starkware
dan-starkware previously approved these changes Jul 12, 2023
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@nagmo-starkware nagmo-starkware dismissed dan-starkware’s stale review July 12, 2023 09:59

The merge-base changed after approval.

@nagmo-starkware nagmo-starkware force-pushed the refactor-gateway-for-multiversion-implementation-version-config branch from 9b7b466 to 5d7d39a Compare July 12, 2023 09:59
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

@nagmo-starkware nagmo-starkware added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 6616719 Jul 12, 2023
15 checks passed
@nagmo-starkware nagmo-starkware deleted the refactor-gateway-for-multiversion-implementation-version-config branch July 12, 2023 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants