prefix spec resource with version id

[nagmo-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[nagmo-starkware]

Current dependencies on/for this PR:

• main
  • PR move block into version specific module #829
    • PR mobe state into version specific module #830
      • PR mobe depracted_contract_class into version specific module #831
        • PR move transactions into version specific module #832
          • PR move version_config out of api into main gateway src #833
            • PR move api into main specific version folder #834
              • PR prefix spec resource with version id #837 👈
                • PR move contract class tests to its one file #845
                  • PR move event chunk and gatway contract class structs to version folder #846
                  • PR use super for version imports #850
                  • PR prepare v0.3.0 for v0.4.0 addition #875
                  • PR remove brodcasted transactions #876
                  • PR rename into rpc method #880
                  • PR starknet api version change #879
                  • PR storage changes #882
                  • PR more storage changes #883
                  • PR unneeded changes? #885
                  • PR add v0.4.0 not connected to endpoint #877
                  • PR feat: add tracing test to cargo #878
                  • PR connect v0.4.0 to api endpoint #881
                  • PR add missing types in test utils #884
                  • PR add support for v0.4.0 #872

This comment was auto-generated by Graphite.

[codecov]

Codecov Report

Merging #837 (762819c) into main (fa6d9ea) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   72.03%   72.03%           
=======================================
  Files          46       46           
  Lines        4399     4399           
  Branches     4399     4399           
=======================================
  Hits         3169     3169           
  Misses        569      569           
  Partials      661      661           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dan-starkware]

crates/papyrus_gateway/src/test_utils.rs line 39 at r1 (raw file):

    version_id: &str,
) -> JSONSchema {
    let target = format!("./resources/{}_starknet_api_openrpc.json", version_id);

Can you use the following?

Suggestion:

format!("./resources/{version_id}_starknet_api_openrpc.json");

[dan-starkware]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware and @nagmo-starkware)

[dan-starkware]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @DvirYo-starkware and @nagmo-starkware)

---

crates/papyrus_gateway/src/v0_3_0/api/test.rs line 42 at r3 (raw file):

    JsonRpcError, Tag,
};
use crate::test_utils::{

Is this related to the PR?

[nagmo-starkware]

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @dan-starkware and @DvirYo-starkware)

---

crates/papyrus_gateway/src/v0_3_0/api/test.rs line 42 at r3 (raw file):

Previously, dan-starkware wrote…

Is this related to the PR?

yes I'm sending the version name to put it in the shcema path

[dan-starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @DvirYo-starkware)

[dan-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

[dan-starkware]

Reviewed 1 of 2 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)

[dan-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @DvirYo-starkware)