docs: 🚧 separate algorithm vignette, plus pseudocode for internals #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
…he inputs go to exclusion functions
…s/osdc into update-function-flow
…s/osdc into update-function-flow
Autoformatting made a few changes after resolving previous merge conflict.
…drugs with a dual-use for weightloss.
Co-authored-by: Luke W. Johnston <[email protected]>
…s/osdc into update-function-flow
Reformatted output variable lists to start with variable names, followed by a short description. Also added info on renamed variables.
…e_lpr2() function
…xcessive. Added a bit more detail to the raw_inclusion_date vs stable_inclusion_date.
Co-authored-by: Signe Kirk Brødbæk <[email protected]>
…te-function-flow # Conflicts: # vignettes/function-flow.Rmd
…s/osdc into update-function-flow
…/design-into-algorithm-and-pseudocode
signekb
added a commit
that referenced
this pull request
Dec 22, 2024
signekb
reviewed
Dec 22, 2024
| #' with the following columns: | ||
| #' | ||
| #' - `pnr`: The personal identification variable. | ||
| #' - `date`: The date of all the recorded diagnosis (renamed from `d_inddto`). |
There was a problem hiding this comment.
Suggested change
| #' - `date`: The date of all the recorded diagnosis (renamed from `d_inddto`). | |
| #' - `date`: The date of all recorded diagnoses (renamed from `d_inddto`). |
signekb
reviewed
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on the wonderful work that @Aastedet started in #133, I started splitting out the algorithm details from the internal function implementation details. I also converted a lot of his text into pseudocode so we can just cut and paste as we develop them.
I'm still ongoing with this, but it's looking amazing so far!!