[2.9 Manual Backport] Support messages that are greater than 1024 characters #408
Conversation
|
/cherry-pick release-2.8 |
|
@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The v1 Event API supports large messages, but if new fields are specified, the Kubernetes API converts it to a events.k8s.io/v1 Event which has a limit of 1024 characters. The solution was to stop setting the eventTime field so that it stays a v1 Event. Relates: https://issues.redhat.com/browse/ACM-13720 Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
backport-long-msg
branch
from
1e0c2c9
to
4b5dc2f
Compare
Coverage merging is failing in Go versions older than 1.22 because a gocovmerge dependency requires Go 1.22. gocovmerge isn't a module, so there is no versions pinned, so go install uses the latest version of the dependency which causes the failure. Signed-off-by: mprahl <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/retest |
openshift-merge-bot
bot
merged commit 1ab9da5
into
stolostron:release-2.9
|
@mprahl: new pull request created: #409 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Backports #394