[release-2.8] [2.9 Manual Backport] Support messages that are greater than 1024 characters #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v1 Event API supports large messages, but if new fields are specified, the Kubernetes API converts it to a events.k8s.io/v1 Event which has a limit of 1024 characters. The solution was to stop setting the eventTime field so that it stays a v1 Event. Relates: https://issues.redhat.com/browse/ACM-13720 Signed-off-by: mprahl <[email protected]>
Coverage merging is failing in Go versions older than 1.22 because a gocovmerge dependency requires Go 1.22. gocovmerge isn't a module, so there is no versions pinned, so go install uses the latest version of the dependency which causes the failure. Signed-off-by: mprahl <[email protected]>
|
dhaiducek
approved these changes
Oct 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit da4beaa
into
stolostron:release-2.8
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #408
/assign mprahl