Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.8] [2.9 Manual Backport] Support messages that are greater than 1024 characters #409

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[release-2.8] [2.9 Manual Backport] Support messages that are greater than 1024 characters #409

merged 2 commits into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. Support messages that are greater than 1024 characters 

    The v1 Event API supports large messages, but if new fields are
specified, the Kubernetes API converts it to a events.k8s.io/v1 Event
which has a limit of 1024 characters.

The solution was to stop setting the eventTime field so that it stays a
v1 Event.

Relates:
https://issues.redhat.com/browse/ACM-13720

Signed-off-by: mprahl <[email protected]>
    @mprahl
    mprahl authored and openshift-cherrypick-robot committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    601fe56 View commit details
    Browse the repository at this point in the history

  2. Remove call to coverage-verify 

    Coverage merging is failing in Go versions older than 1.22 because a gocovmerge
dependency requires Go 1.22. gocovmerge isn't a module, so there is no versions
pinned, so go install uses the latest version of the dependency which
causes the failure.

Signed-off-by: mprahl <[email protected]>
    @mprahl
    mprahl authored and openshift-cherrypick-robot committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    661ac29 View commit details
    Browse the repository at this point in the history