Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.redhat.com/browse/ACM-16145--pm request for disconnect… (delayed) #7480

Open
wants to merge 2 commits into
base: 2.12_stage
Choose a base branch
from
Open

https://issues.redhat.com/browse/ACM-16145--pm request for disconnect… (delayed) #7480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9e064d
https://issues.redhat.com/browse/ACM-16145--pm request for disconnect…
swopebe Feb 6, 2025
d07c7fb
https://issues.redhat.com/browse/ACM-16145--creating information abou…
swopebe Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clusters/cluster_lifecycle/release_image_intro.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ Continue reading to learn more about release images:
* xref:../cluster_lifecycle/release_images_specify.adoc#release-images-specify[Specifying release images]
* xref:../cluster_lifecycle/release_image_connected.adoc#release-images-connected[Maintaining a custom list of release images while connected]
* xref:../cluster_lifecycle/release_image_disconn.adoc#release-images-disconnected[Maintaining a custom list of release images while disconnected]
* xref:../cluster_lifecycle/sync_release_image.adoc#synchronizing-available-release-images[Synchronizing available release images]
* xref:../cluster_lifecycle/release_image_sync.adoc#synchronizing-available-release-images[Synchronizing available release images]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the name and all links to reflect how the rest of the files are named so I don't have to keep hunting for it!

0 ...cluster_lifecycle/sync_release_image.adoc → ...cluster_lifecycle/release_image_sync.adoc
View file
Open in desktop
File renamed without changes.
25 changes: 18 additions & 7 deletions clusters/cluster_lifecycle/specify_img_registry.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,24 @@
[#specify-registry-img-on-managed-clusters-for-import]
= Specifying image registry on managed clusters for import

You might need to override the image registry on the managed clusters that you are importing. You can do this by creating a `ManagedClusterImageRegistry` custom resource definition.
You might need to override the image registry on the managed clusters that you are importing by creating a `ManagedClusterImageRegistry` custom resource definition. The `ManagedClusterImageRegistry` custom resource definition specifies a set of managed clusters for a `placement` to select, but needs different images from the custom image registry.

The `ManagedClusterImageRegistry` custom resource definition is a namespace-scoped resource.
{acm-short} retrieves {ocp-short} `ClusterImageSets` from a GitHub repository that is managed by Red Hat. These `ClusterImageSets` define {ocp-short} versions that can be deployed.

The `ManagedClusterImageRegistry` custom resource definition specifies a set of managed clusters for a Placement to select, but needs different images from the custom image registry. After the managed clusters are updated with the new images, the following label is added to each managed cluster for identification: `open-cluster-management.io/image-registry=<namespace>.<managedClusterImageRegistryName>`.
*Important:* You might need to obtain _ClusterImageSets_ without access to GitHub.

The following example shows a `ManagedClusterImageRegistry` custom resource definition:
+
Copy link
Contributor Author

@swopebe swopebe Feb 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content added here that we can go over.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full steps and details for adding a ManagedClusterIMageRegistry are here: https://docs.redhat.com/en/documentation/red_hat_advanced_cluster_management_for_kubernetes/2.12/html/clusters/cluster_mce_overview#specify-registry-img-on-managed-clusters-for-import ... so can we just advise them to review that directly?

Copy link
Contributor Author

@swopebe swopebe Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the template, I look at step 4 and that's how I know what needs to be added:

https://issues.redhat.com/browse/ACM-16145

Are we saying we don't need the content that I added--just the link? Since we are pretty swamped right now, I need to table this to work on some other items and will wait for response.

If you cannot access the repository that you need to specify an image registry because you are not connected to the Internet, or because of policy settings, you might need to take additional steps to access a _mirrored_ or _internal_ repository​. See xref:../cluster_lifecycle/release_image_disconn.adoc#release-images-disconnected[Maintaining a custom list of release images while disconnected] for that procedure.

* <<config-managedclusterimageregistry,Configure the _ManagedClusterImageRegistry_>>
* <<import-cluster-managedclusterimageregistry,Importing a cluster that has a _ManagedClusterImageRegistry_>>

[#config-managedclusterimageregistry]
== Configure the _ManagedClusterImageRegistry_

The `ManagedClusterImageRegistry` custom resource definition is a namespace-scoped resource. After the managed clusters are updated with the new images, the following label is added to each managed cluster for identification: `open-cluster-management.io/image-registry=<namespace>.<managedClusterImageRegistryName>`.

The following example shows a `ManagedClusterImageRegistry` custom resource definition with `placementRef` specifications:

[source,yaml]
----
Expand All @@ -29,7 +40,7 @@ spec:
- mirror: <mirrored-image-registry-address>
source: <image-registry-address>
----
<1> Replace with the name of a Placement in the same namespace that selects a set of managed clusters.
<1> Replace with the name of a `placement` in the same namespace that selects a set of managed clusters.
<2> Replace with the name of the pull secret that is used to pull images from the custom image registry.
<3> List the values for each of the `source` and `mirror` registries. Replace the `mirrored-image-registry-address` and `image-registry-address` with the value for each of the `mirror` and `source` values of the registries.

Expand Down Expand Up @@ -89,7 +100,7 @@ $ kubectl create secret docker-registry myPullSecret \
--docker-password=<my-password>
----

. Create a Placement in the namespace that you created.
. Create a `placement` in the namespace that you created.
+
[source,yaml]
----
Expand All @@ -106,7 +117,7 @@ spec:
operator: Exists
----
+
*Note:* The `unreachable` toleration is required for the Placement to be able to select the cluster.
*Note:* The `unreachable` toleration is required for the `placement` to be able to select the cluster.

. Create a `ManagedClusterSet` resource and bind it to your namespace.
+
Expand Down
2 changes: 1 addition & 1 deletion clusters/main.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ include::cluster_lifecycle/release_image_intro.adoc[leveloffset=+3]
include::cluster_lifecycle/release_images_specify.adoc[leveloffset=+4]
include::cluster_lifecycle/release_image_connected.adoc[leveloffset=+4]
include::cluster_lifecycle/release_image_disconn.adoc[leveloffset=+4]
include::cluster_lifecycle/sync_release_image.adoc[leveloffset=+4]
include::cluster_lifecycle/release_image_sync.adoc[leveloffset=+4]
include::cluster_lifecycle/create_intro.adoc[leveloffset=+3]
include::cluster_lifecycle/create_cluster_cli.adoc[leveloffset=+4]
include::cluster_lifecycle/config_manifest_create.adoc[leveloffset=+4]
Expand Down