Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline dependencies of docker CI images Part 2 #952

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

ahnaf-tahmid-chowdhury
Copy link
Member

Description

This PR aims to streamline the dependencies of Docker CI images by removing autoconf and extra docker stages moab and hdf5, and merging them into the external_stage stage. HDF5 will now be built using CMake instead of autoconf.

Changes Made

  • Removed autoconf dependency.
  • Merged moab and hdf5 stages into the external_stage stage.
  • Built HDF5 using CMake instead of autoconf.

@ahnaf-tahmid-chowdhury
Copy link
Member Author

Bad luck. It appears that HDF5 requires CMake 3.18 as the minimum version for support in the find_package method. However, Ubuntu 20.04 only has CMake 3.16. Any suggestions?

@gonuke
Copy link
Member

gonuke commented Mar 6, 2024

Bad luck. It appears that HDF5 requires CMake 3.18 as the minimum version for support in the find_package method. However, Ubuntu 20.04 only has CMake 3.16. Any suggestions?

Hmmm.... I guess we could drop 20.04 support? We're only a few weeks away from 24.04 being released....

@@ -59,7 +59,7 @@ runs:
}}-double_down_${{
inputs.double_down_version
}}
stages: base, external_deps, hdf5, moab, dagmc
stages: base, external_deps, dagmc
server-stage: dagmc_test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How it works? I have noticed it just caching everything. And tests are already passed on the final stage. Maybe I have misconfigured something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you expect to be different?

@@ -75,7 +74,7 @@ jobs:
uses: firehed/multistage-docker-build-action@v1
with:
repository: ${{ env.image_base_tag }}
stages: base, external_deps, hdf5, moab, dagmc
stages: base, external_deps, dagmc, final
server-stage: dagmc_test
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'd like to ask my previous question here. I believe the final stage could be set as server-stage, and dagmc_test may be moved to stages part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I put dagmc_test to stages and final to server-stage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes a lot of different for our purposes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we are good to go.

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahnaf-tahmid-chowdhury - this creates a lot of different packages. At some point we'll want to clean them up and remove the deprecated ones.

@gonuke gonuke merged commit 7e1cdb6 into develop Mar 30, 2024
65 checks passed
@ahnaf-tahmid-chowdhury
Copy link
Member Author

Please explain or make an issue. I will try to solve that accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants