-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline dependencies of docker CI images Part 2 #952
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ jobs: | |
strategy: | ||
matrix: | ||
ubuntu_version : [ | ||
20.04, | ||
22.04, | ||
] | ||
compiler : [ | ||
|
@@ -75,7 +74,7 @@ jobs: | |
uses: firehed/multistage-docker-build-action@v1 | ||
with: | ||
repository: ${{ env.image_base_tag }} | ||
stages: base, external_deps, hdf5, moab, dagmc | ||
stages: base, external_deps, dagmc, final | ||
server-stage: dagmc_test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I'd like to ask my previous question here. I believe the final stage could be set as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I put There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think it makes a lot of different for our purposes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then we are good to go. |
||
quiet: false | ||
parallel: true | ||
|
@@ -97,7 +96,6 @@ jobs: | |
strategy: | ||
matrix: | ||
ubuntu_version : [ | ||
20.04, | ||
22.04, | ||
] | ||
compiler : [ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,6 @@ jobs: | |
strategy: | ||
matrix: | ||
ubuntu_version : [ | ||
20.04, | ||
22.04, | ||
] | ||
compiler : [ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How it works? I have noticed it just caching everything. And tests are already passed on the final stage. Maybe I have misconfigured something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you expect to be different?