Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast boolean env variables #632

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cast boolean env variables #632

wants to merge 2 commits into from

Conversation

SeyamMs
Copy link

@SeyamMs SeyamMs commented Jun 12, 2024

Inspired by #164

Environment variables are always casted to strings, so added PHP filter_var() to cast $_SERVER variables at if statements.

I think for argument PANTHER_DEVTOOLS its required to be able to set it to false, while for arguments PANTHER_NO_HEADLESS and PANTHER_NO_SANDBOX are false by default and true if they just defined.

Hence, another applicable solution is to convert PANTHER_DEVTOOLS to PANTHER_NO_DEVTOOLS

@nicolas-grekas
Copy link
Member

Can you please rebase so that we can trigger the CI again also?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants