Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SSO name for config-profiles block #871

Merged
merged 2 commits into from
Jun 12, 2024

Fix `config-profiles` with multiple SSO instances

4b100c7
Select commit
Loading
Failed to load commit list.
Merged

use SSO name for config-profiles block #871

Fix `config-profiles` with multiple SSO instances
4b100c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 12, 2024 in 0s

82.93% (+1.36%) compared to 0d9616d

View this Pull Request on Codecov

82.93% (+1.36%) compared to 0d9616d

Details

Codecov Report

Attention: Patch coverage is 74.13793% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (0d9616d) to head (4b100c7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   81.56%   82.93%   +1.36%     
==========================================
  Files          38       38              
  Lines        2723     2741      +18     
==========================================
+ Hits         2221     2273      +52     
+ Misses        427      383      -44     
- Partials       75       85      +10     
Files Coverage Δ
internal/awsconfig/config.go 80.65% <100.00%> (+0.65%) ⬆️
sso/awssso_auth.go 85.29% <100.00%> (+0.26%) ⬆️
internal/predictor/predictor.go 84.78% <50.00%> (+2.76%) ⬆️
internal/utils/fileedit.go 70.48% <79.17%> (+1.48%) ⬆️
internal/helper/helper.go 69.00% <61.90%> (+40.28%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9616d...4b100c7. Read the comment docs.