Update workflow; python in particular #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully should work with node20? Might need v4 for that. Relative paths don't work, cf actions/upload-artifact#176
For now, switch to upload v1, which allows relative filenames.
Rename wheel files as we go. Fix typo in filename.
Problem on manylinux where the setup.py was changed but not overwritten. This is overkill, but hopefully will prevent any such similar problems.
Also, run final python tests if 'python' and 'tests' are on; don't check 'Release'.
* Use bash more often; explicitly use Windows 'pipe' when needed. * Change python_v#_name to v# instead of referencing python version. * Split C tests from Python tests. * Include roadrunner version number in name of artifacts.
luciansmith
merged commit 3b10dec
into
move-CI/CD-workflow-to-GitHub-Actions
26 of 28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, python is now build for each platform in series instead of in parallel, with the earliest and latest versions of python tested. Other elements are updated to use slightly more recent versions of actions, so hopefully it won't be too difficult to upgrade to node20 when we have to.