Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jacobian #1242

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Fix jacobian #1242

merged 4 commits into from
Jan 28, 2025

Conversation

luciansmith
Copy link

@bartjuw 's correcting the calculation of Jacobians in models with non-unary compartments.

Update getFullJacobian, getReducedJacobian to handle reactions between species in different compartments of differing volumes. Affects getEigenValues() results.
@luciansmith luciansmith reopened this Jan 28, 2025
@luciansmith luciansmith merged commit e67599e into develop Jan 28, 2025
9 checks passed
@luciansmith luciansmith deleted the fix_jacobian branch January 28, 2025 21:54
@luciansmith
Copy link
Author

Thanks, @bartjuw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants