drivers: add grant method for all driver spaces #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
reviewed
Oct 8, 2024
themilchenko
force-pushed
the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
from
c220d82
to
351c6e8
Compare
oleg-jukovec
reviewed
Oct 9, 2024
themilchenko
force-pushed
the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
from
351c6e8
to
e2e10c8
Compare
Added. |
oleg-jukovec
reviewed
Oct 9, 2024
oleg-jukovec
approved these changes
Oct 9, 2024
themilchenko
force-pushed
the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
from
e2e10c8
to
86dfb4e
Compare
DerekBum
approved these changes
Oct 9, 2024
themilchenko
force-pushed
the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
from
86dfb4e
to
573d8ed
Compare
oleg-jukovec
reviewed
Oct 9, 2024
There was a bug that grant for a user didn't work for spaces with `_ready_buffer` suffix. After the patch the `grant` method was added for each driver that accounts the `grant` for all spaces. Closes #237
It wasn impossible to download tarantool for tests running. After the patch the ubuntu verstion was edited from `latest` to `22.04` in CI.
themilchenko
force-pushed
the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
from
573d8ed
to
3416d11
Compare
oleg-jukovec
deleted the
themilchenko/gh-237-fix-ready-buffer-space-grants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug that grant for a user didn't work for spaces with
_ready_buffersuffix.After the patch the
grantmethod was added for each driver that accounts thegrantfor all spaces.Closes #237