-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Core & add HTTP Otel / Dev UI Port #407
Conversation
c88760c
to
778c7db
Compare
778c7db
to
9f8374b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for knocking out some of my issues while here. Only a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, but could make this a nested enum inside the OpenTelemetryOptions
as just Protocol
if you'd like, but here is fine too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stuck with what temporality did
await EncodeAsync( | ||
codec, cmd.ScheduleNexusOperation.Input).ConfigureAwait(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we surround this with the if-not-null check? Hopefully as of #405 CI will break anyways. (EDIT: it does break in CI, whew)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. IMO these should all just check for nullity internally. Feels a bit silly to protect all of them individually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be ok with that change if you want to make it or open an issue for us to make it later. I think originally I was unnecessarily trying to reduce call counts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. Don't like the new top-level file, but not a big deal.
What was changed
Why?
Checklist
Closes [Feature Request] Allow customization of dev server UI port #396
closes [Feature Request] OTel metrics over HTTP #392
How was this tested:
Core tests should be sufficient. Manually verified UI port is set properly.
Any docs updates needed?